perl: update patches so that they can be applied to perl 5.22.3 #27042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aycanirican
changed the title
0xABAB
reviewed
Jul 2, 2017
There was a problem hiding this comment.
This is horrible to review. Can you elaborate a bit on the back story on why we need to have this patch in our repository in the first place and why the Perl people can't supply a patch that just works out of the box? Perhaps this is a problem that Nix creates, but since it's annoying to review in patch format (it's basically a patch of a patch), I'd like to never see that again.
Having said that, thanks for taking the time to work on this horrible thing.
|
No idea what the cpp patch is for, but the other patch is Nix specific in that it helps enforce purity (prevent picking up references to/using stuff outside the Nix store). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Perl patches
cpp-precomp.patchandno-sys-dirs.patchcannot be applied to perl-5.22.3 source and was giving HUNKS. This commit fixes those patches so that they can be applied cleanly.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)