use /nix/var/tmp as default tmpRoot #1085
Conversation
the default TMPDIR on OSX is set to a pretty long path in /var/folders this causes unit tests that try to create unix domain sockets in the build directory or a TMPDIR to fail.
|
IMHO we shouldn't add more non-standard directories. If I wrote it today, I would use |
|
Fine by me as long as we end up with shorter names. Although in practice /var is a symlink to /private/var on OSX. But that's not much longer
|
|
Perhaps |
|
For an entire platform?
|
|
Well, in Darwin case some platform-specific default might be useful. There's also the case that on NixOS we have tmp-on-tmpfs by default, which might be too small for nix builds in some setups. |
|
The tmpOnTmpfs option is the reason why I didn't use |
|
What is going to manage the cleanup of this |
|
@shlevy would long-shebang help here? |
|
No, the problem here is a stupid limit in the types that specify a socket address, baked in to the kernel. |
|
Oh, |
|
With the daemon this can be configured in the service without impacting a user's shell. That's a better solution then introducing another |
* Replace LD_LIBRARY_PATH with OS-specific name (e.g. DYLD_LIBRARY_PATH on macOS). * Disable Python tests on macOS, because they use gpg, which fails due to a very long socket path (NixOS/nix#1085). The former should be fixed upstream. The latter is a Nix-specific issue, but it can be worked-around upstream by making Python tests respect --disable-gpg-test.
the default TMPDIR on OSX is set to a pretty long path in /var/folders
this causes unit tests that try to create unix domain sockets in the
build directory or a TMPDIR to fail.
This change uses
/nix/var/tmpby default even ifTMPDIRis set, but it's still overridable withNIX_TMPDIRThis still builds with this change for example: https://gist.github.com/LnL7/cdf69b7f231bdedfef5c11ce0c276c7f