add config.services.xserver.windowManager.sway #19663

tg-x · 2016-10-18T20:18:09Z

Motivation for this change

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2016-10-18T20:18:11Z

@tg-x, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @AndersonTorres and @edolstra to be potential reviewers.

tg-x · 2016-10-18T20:37:08Z

needs wayland-compatible display manager such as SDDM or GDM (tested with SDDM)

Ericson2314 · 2016-10-18T21:18:27Z

Is this x+wayland? Either way its good progress!

tg-x · 2016-10-18T21:29:39Z

yes, the display manager still runs on X, this just adds the option to select sway, that would run in a wayland session

groxxda · 2016-10-18T22:25:54Z

Thanks for the work. Obviously this should not be part of services.xserver, but fixing this is a whole other issue. So it's probably ok for now.

Another thing:
At least GDM decides which session (x or wayland) is needed by looking at the path of the .desktop file. If I remember correctly, support for GDM-Session-Type (or similar) was dropped again.

I would really appreciate it, if you tested this with gdm 3.22 from #19081 which itself uses wayland instead of X and see if it works. I might give it a shot myself when I find time.

ericsagnes · 2016-11-29T07:02:06Z

nixos/modules/services/x11/window-managers/sway.nix

+
+{
+  options.services.xserver.windowManager = {
+    sway = swayOption "sway";


Why using a function to generate the options?

this is based on i3.nix, sure it does not need the function or mkMerge anymore, could be simplified..

Please do so, that will improve the readability and maintainability of the module.
For the record, i3 module was simplified in #20385.

ericsagnes · 2016-11-29T07:06:09Z

nixos/modules/services/x11/window-managers/sway.nix

+  };
+
+  config = mkMerge [
+    (mkIf wmCfg.sway.enable (swayConfig "sway" pkgs.sway wmCfg.sway))


Why using a mkMerge and a function to generate the config?

vikstrous · 2017-01-26T09:33:14Z

I tested this out. I was using slim. Sway started and it even loaded my i3 config and ran i3status without me creating a separate sway config. However, whenever I tried to create a terminal, the process started but it was not visible on the screen. Looking at the process tree in htop I could see all of my terminals and they were all under pid 1. Everything looked normal, I just couldn't see them.

matthiasbeyer · 2017-01-30T09:30:38Z

This is awesome progress!

Note that in #21808 sway will be updated, which might result in unexpected things after the merge.

I would vote for an options.services.graphics.xserver option, keeping options.services.xserver to be backwards compatible.
But sure, this is another issue and should be discussed elsewhere.

Mic92 · 2017-02-21T23:29:34Z

Can you add a setcap wrapper as described in the README.md using our new setcap wrapper module?

bobvanderlinden · 2018-10-28T17:23:35Z

Is this PR still relevant?

Mic92 · 2018-10-28T18:27:04Z

Relevant yes, up-to-date no.

colemickens · 2019-03-18T18:08:34Z

This can be closed. It's not longer relevant or up-to-date.

matthew-piziak · 2019-03-18T20:56:06Z

@colemickens So Sway will not be supported in NixOS?

colemickens · 2019-03-18T20:57:42Z

@matthew-piziak oh no, I'm sorry I didn't explain more. There is already a Sway package and module in nixpkgs now!

bobvanderlinden · 2019-03-19T15:33:57Z

Reference: https://github.com/NixOS/nixpkgs/blob/release-18.09/nixos/modules/programs/sway.nix

matthew-piziak · 2019-03-19T17:44:36Z

Weird, if I add programs.sway.enable = true; to my configuration.nix and also put "sway" in my extraGroups, then running sway gives me Couldn't exec sway-setcap: Permission denied.

Getting a permission error is weird, given that I'm part of the group.

If I run sway as root, I get 03/19/19 13:42:51 - [main.c:48] [wlc] Failed to add socket to wayland display.

colemickens · 2019-03-19T18:20:07Z

You're not up to date if you're getting errors about setcap and wlc.

See this commit: NixOS/nixpkgs-channels@45004c6 It's in nixos-unstable and I know the change was ported into the 19.03 channel as well.

matthew-piziak · 2019-03-20T18:51:43Z

Ah, thanks. Unfortunately NVIDIA drivers do not build on 19.03, and sway does not build on 18.09. NVIDIA is more important to me. I haven't figured out how to import program configuration from specific channels (like sway from unstable, for example). I only know how to do it for packages, not programs. I don't suppose you know how to do that?

colemickens · 2019-03-20T19:11:46Z

Sway 1.0 explicitly will refuse to start with nvidia drivers, anyway. You'd need to use nouvaeu.
The NUR supposedly has examples of importing modules but I've never gotten it to work. I actually wanted to do this as part of nixpkgs-wayland.

matthew-piziak · 2019-03-20T19:54:33Z

Oh, and there's no way to use one set of drivers for sway and one for everything else right? Probably a silly question but I really don't know. Prooobably not going to give up the graphics card performance in exchange for this window manager.

Thanks for answering my questions!

bobvanderlinden · 2019-04-13T22:09:35Z

Which features are in this PR that aren't on master? If there aren't any, please close this PR. (making an attempt to clean up older PRs)

moaxcp · 2019-10-04T16:18:35Z

Which features are in this PR that aren't on master? If there aren't any, please close this PR. (making an attempt to clean up older PRs)

I don't see any of these features in master.

colemickens · 2019-10-04T20:36:02Z

Aren't they on master under programs.sway ? https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/sway.nix

moaxcp · 2019-10-05T13:07:20Z

Aren't they on master under programs.sway ? https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/sway.nix

Yes they are! It makes sense to close then.

add config.services.xserver.windowManager.sway

623ea38

tg-x mentioned this pull request Oct 18, 2016

Add Wayland Support #5071

Closed

13 tasks

config.services.xserver.windowManager.sway.debug

59260c6

ericsagnes reviewed Nov 29, 2016

View reviewed changes

Mic92 mentioned this pull request Feb 21, 2017

Sway: module #23059

Closed

2 tasks

This was referenced Oct 19, 2017

sway: 0.13.0 -> 0.14.0 #30493

Merged

sway module: make it useful to end user #30800

Merged

joachifm closed this Oct 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add config.services.xserver.windowManager.sway #19663

add config.services.xserver.windowManager.sway #19663

tg-x commented Oct 18, 2016

mention-bot commented Oct 18, 2016

tg-x commented Oct 18, 2016

Ericson2314 commented Oct 18, 2016

tg-x commented Oct 18, 2016

groxxda commented Oct 18, 2016

ericsagnes Nov 29, 2016

tg-x Dec 2, 2016

ericsagnes Dec 3, 2016

ericsagnes Nov 29, 2016

vikstrous commented Jan 26, 2017

matthiasbeyer commented Jan 30, 2017

Mic92 commented Feb 21, 2017 •

edited

bobvanderlinden commented Oct 28, 2018

Mic92 commented Oct 28, 2018

colemickens commented Mar 18, 2019

matthew-piziak commented Mar 18, 2019

colemickens commented Mar 18, 2019

bobvanderlinden commented Mar 19, 2019

matthew-piziak commented Mar 19, 2019

colemickens commented Mar 19, 2019

matthew-piziak commented Mar 20, 2019

colemickens commented Mar 20, 2019

matthew-piziak commented Mar 20, 2019

bobvanderlinden commented Apr 13, 2019 •

edited

moaxcp commented Oct 4, 2019

colemickens commented Oct 4, 2019

moaxcp commented Oct 5, 2019

add config.services.xserver.windowManager.sway #19663

add config.services.xserver.windowManager.sway #19663

Conversation

tg-x commented Oct 18, 2016

Motivation for this change

Things done

mention-bot commented Oct 18, 2016

tg-x commented Oct 18, 2016

Ericson2314 commented Oct 18, 2016

tg-x commented Oct 18, 2016

groxxda commented Oct 18, 2016

ericsagnes Nov 29, 2016

Choose a reason for hiding this comment

tg-x Dec 2, 2016

Choose a reason for hiding this comment

ericsagnes Dec 3, 2016

Choose a reason for hiding this comment

ericsagnes Nov 29, 2016

Choose a reason for hiding this comment

vikstrous commented Jan 26, 2017

matthiasbeyer commented Jan 30, 2017

Mic92 commented Feb 21, 2017 • edited

bobvanderlinden commented Oct 28, 2018

Mic92 commented Oct 28, 2018

colemickens commented Mar 18, 2019

matthew-piziak commented Mar 18, 2019

colemickens commented Mar 18, 2019

bobvanderlinden commented Mar 19, 2019

matthew-piziak commented Mar 19, 2019

colemickens commented Mar 19, 2019

matthew-piziak commented Mar 20, 2019

colemickens commented Mar 20, 2019

matthew-piziak commented Mar 20, 2019

bobvanderlinden commented Apr 13, 2019 • edited

moaxcp commented Oct 4, 2019

colemickens commented Oct 4, 2019

moaxcp commented Oct 5, 2019

Mic92 commented Feb 21, 2017 •

edited

bobvanderlinden commented Apr 13, 2019 •

edited