Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better rle output size handling and documentation (SF feat req 80). #197

Closed
wants to merge 2 commits into from

Conversation

d-lamb
Copy link
Member

@d-lamb d-lamb commented Sep 28, 2016

One thing I didn't think about was the signature of rle: it will still show as c(n); indx [o]a(n); [o]b(n); but in reality the signature will be c(n); indx [o]a(m); [o]b(m); where m<=n.

This adds a wrapper around the pp_def'd rle code so that rle() output
is no bigger than it needs to be. This removes the necessity of
manually truncating the output in the common 1D use case. Also
adds (hopefully) improved documemtation for rle, and a few new tests.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 62.994% when pulling 19b3a39 on sf080_rle into 4163a82 on master.

This required some very light PP acrobatics to allow a & b to have
different dimension than c but still make threading work OK.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 62.994% when pulling 2151584 on sf080_rle into 4163a82 on master.

@wchristian wchristian closed this Oct 1, 2016
@wchristian wchristian deleted the sf080_rle branch October 1, 2016 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants