php: build embedded, uwsgi: enable php plugin #19139

schneefux · 2016-10-01T17:38:37Z

Allows to run uwsgi with the PHP plugin.
The plugin needs embedded PHP, so I added php70-embed. (@globin)

Usage example:

location ~ (index)\.php$ {
  include ${pkgs.nginx}/conf/uwsgi_params;
  uwsgi_modifier1 14;
  uwsgi_pass unix:/run/uwsgi/php.sock;
}

services.uwsgi = {
  enable = true;
  user = "nginx";
  group = "nginx";
  instance = {
    type = "emperor";
    vassals = {
      php = {
        type = "normal";
        socket = "/run/uwsgi/php.sock";
        master = true;

        processes = 16;
        cheaper = 1;
        php-sapi-name = "apache";
        php-allowed-ext = [ ".php" ".inc" ];
        socket-modifier1 = 14;
        php-index = "index.php";

        php-set = "date.timezone=Europe/Berlin";
        env = "NEXTCLOUD_CONFIG_DIR=/var/www/nextcloud/config";

        plugins = [ "php" ];
      };
    };
  };
  plugins = [ "php" ];

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2016-10-01T17:38:46Z

@schneefux, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @dezgeg to be potential reviewers.

ericsagnes · 2016-10-01T17:49:02Z

pkgs/development/interpreters/php/default.nix

@@ -228,6 +232,7 @@ let
        pdo_mysqlSupport = config.php.pdo_mysql or true;
        libxml2Support = config.php.libxml2 or true;
        apxs2Support = config.php.apxs2 or (!stdenv.isDarwin);
+        embedSupport = config.php.embed or false;


Maybe this could be true as default so there would be no need for another top-level php attribute?

No. Only one SAPI can be built at a time, either "apxs2" or "embed" in this case.

Could assure with an assert, that either one or the other option is used? You could also add one option which is either set either to apxs2 or embed.

Is that needed? When compiling with both flags, php shows this message:

checking for embedded SAPI library support... configure: error: +--------------------------------------------------------------------+ | *** ATTENTION *** | | | | You've configured multiple SAPIs to be build. You can build only | | one SAPI module plus CGI, CLI and FPM binaries at the same time. | +--------------------------------------------------------------------+

I think that's sufficient - maybe it will be possible to build multiple SAPIs in future PHP versions.

ericsagnes · 2016-10-01T17:52:09Z

pkgs/development/interpreters/php/default.nix

+              --replace '@CONFIGURE_OPTIONS@' "" \
+              --replace '@PHP_LDFLAGS@' ""
+          done
+        fi



if ${if (config.php.embed or false) == false then "true" else "false"}; then

can be all done in nix, eg:

${optionalString config.php.embed ''...''}

That gives me attribute php missing.

Use (config.php.embed or false).

abbradar · 2016-10-01T18:58:38Z

pkgs/servers/uwsgi/default.nix

@@ -74,7 +79,7 @@ stdenv.mkDerivation rec {
  buildPhase = ''
    mkdir -p $pluginDir
    python3 uwsgiconfig.py --build nixos
-    ${lib.concatMapStringsSep ";" (x: "${x.interpreter or "python3"} uwsgiconfig.py --plugin ${x.path} nixos ${x.name}") needed}
+    ${lib.concatMapStringsSep ";" (x: "${x.preBuild or ""} ${x.interpreter or "python3"} uwsgiconfig.py --plugin ${x.path} nixos ${x.name}") needed}


Add a semicolon after preBuild here so that we wouldn't need to add it in every preBuild by hand. You can fallback to true so that if preBuild is not set it evaluates to true;.

Oh, even better -- use a "\n", then you don't need tricks with true,

schneefux · 2016-10-02T11:01:21Z

@abbradar @ericsagnes I updated the PR with your changes.
Travis fails with configure: error: Cannot find ldap libraries in /usr/lib. I think LDAP_LIBDIR=${openldap.out}/lib needs to be passed in preBuild as seen in php/default.nix, but that doesn't work… php, php-embed and uwsgi build fine for me locally.

abbradar · 2016-10-02T11:38:24Z

@schneefux Enable sandboxing -- this would most likely allow you to reproduce.

schneefux · 2016-10-02T17:00:46Z

@abbradar: My changes are not responsible for the failure, the same error already occurred in #18860. uwsgi php70 php56 php70-embed build fine on Linux and NixOS with sandboxing.

Mic92 · 2016-10-22T06:44:37Z

pkgs/servers/uwsgi/default.nix

@@ -4,7 +4,8 @@
 , pam, withPAM ? false
 , systemd, withSystemd ? false
 , python2, python3, ncurses
-, ruby
+, ruby, php-embed
+, openldap


openldap is not used.

Mic92 · 2016-10-22T06:48:00Z

can you add your php example to nixos/modules/services/web-servers/uwsgi.nix as well?

schneefux · 2016-10-22T13:38:40Z

can you add your php example

I got the example from the official documentation, I added a link.

bachp · 2017-01-19T20:01:16Z

Any chance this gets merged?

Mic92 · 2017-01-20T11:54:10Z

@bachp can you provide me a configuration to test uwsgi + php. Just something which shows that plugin gets initialized.

schneefux · 2017-01-20T18:50:48Z

@Mic92

services.nginx = {
  enable = true;
  virtualHosts = {
    "example.com" = {
      root = "/var/www";
      locations."/".extraConfig = ''
        include ${pkgs.nginx}/conf/uwsgi_params;
        uwsgi_modifier1 14;
        uwsgi_pass unix:${config.services.uwsgi.instance.vassals.php.socket};
      '';
    };
  };
};

services.uwsgi = {
  enable = true;
  user = "nginx";
  group = "nginx";
  instance = {
    type = "emperor";
    vassals = {
      php = {
        type = "normal";
        socket = "/run/uwsgi/php.sock";
        master = true;
        vacuum = true;
        processes = 4;
        cheaper = 1;
        php-sapi-name = "apache"; # performance tweak
        socket-modifier1 = 14;
        php-index = "index.php";
        php-set = [ "session.save_handler=files" "session.save_path=/var/www/sessions" ]; # fixes session issues with Nextcloud
        plugins = [ "php" ];
      };
    };
  };
  plugins = [ "php" ];
};

index.php:

<?php phpinfo(); ?>

ericsagnes reviewed Oct 1, 2016

View reviewed changes

schneefux force-pushed the uwsgi-php branch from c8e2e1d to fe1150b Compare October 1, 2016 17:55

abbradar reviewed Oct 1, 2016

View reviewed changes

schneefux force-pushed the uwsgi-php branch 7 times, most recently from 82fc009 to 85bf33a Compare October 2, 2016 10:26

fpletz approved these changes Oct 8, 2016

View reviewed changes

Mic92 reviewed Oct 22, 2016

View reviewed changes

schneefux force-pushed the uwsgi-php branch from 85bf33a to 67e51cf Compare October 22, 2016 13:36

schneefux added 2 commits January 4, 2017 15:11

php: add embedded package

fe0c14e

uwsgi: enable php plugin

0c4628d

schneefux force-pushed the uwsgi-php branch from 67e51cf to 0c4628d Compare January 4, 2017 14:13

globin self-assigned this Jan 19, 2017

globin merged commit 3f3b6e6 into NixOS:master Jan 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

php: build embedded, uwsgi: enable php plugin #19139

php: build embedded, uwsgi: enable php plugin #19139

schneefux commented Oct 1, 2016

mention-bot commented Oct 1, 2016

ericsagnes Oct 1, 2016

schneefux Oct 1, 2016

Mic92 Oct 22, 2016

schneefux Oct 22, 2016

ericsagnes Oct 1, 2016

schneefux Oct 1, 2016

abbradar Oct 1, 2016

abbradar Oct 1, 2016

abbradar Oct 1, 2016

schneefux commented Oct 2, 2016

abbradar commented Oct 2, 2016

schneefux commented Oct 2, 2016

Mic92 Oct 22, 2016

Mic92 commented Oct 22, 2016 •

edited

schneefux commented Oct 22, 2016

bachp commented Jan 19, 2017

Mic92 commented Jan 20, 2017

schneefux commented Jan 20, 2017

php: build embedded, uwsgi: enable php plugin #19139

php: build embedded, uwsgi: enable php plugin #19139

Conversation

schneefux commented Oct 1, 2016

Things done

mention-bot commented Oct 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

schneefux commented Oct 2, 2016

abbradar commented Oct 2, 2016

schneefux commented Oct 2, 2016

Choose a reason for hiding this comment

Mic92 commented Oct 22, 2016 • edited

schneefux commented Oct 22, 2016

bachp commented Jan 19, 2017

Mic92 commented Jan 20, 2017

schneefux commented Jan 20, 2017

Mic92 commented Oct 22, 2016 •

edited