-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO.copy_stream with Zlib::GZipWriter broken in 9.1.3.0 and up #4202
Comments
@ewr Good theory. I don't suppose you've bisected it? I'll investigate. |
Nope. Just wandered around looking for respond_to, and noticed that change occurred after the release where things broke. |
Oh yeah, this is definitely from that commit. Simple fix coming. This affects any copy_stream cases that need to coerce the streams. Great find and great investigation, thanks! |
For future reference, you can narrow down an exception even more by passing
|
So the actual bug here was that our MRI does not do this. Instead of having a |
In 9.1.3.0 and above, calling
IO.copy_stream
with aZlib::GzipWriter
breaks due toArgumentError: wrong number of arguments calling
respond_to?(2 for 1)
.I suspect it may have come from 9167f3a.
Reproduction script:
Works on 9.0.4.0 and 9.1.2.0. Fails on 9.1.3.0, 9.1.4.0 and 9.1.5.0.
The text was updated successfully, but these errors were encountered: