Skip to content

Emacs all the icons fonts #19152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Emacs all the icons fonts #19152

wants to merge 1 commit into from
+21 −1

Conversation

DamienCassou
Copy link
Contributor

Motivation for this change

all-the-icons is an Emacs package which needs some fonts to work. This PR adds the necessary fonts as propagated build inputs of this package.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@DamienCassou DamienCassou added the 2.status: work-in-progress This PR isn't done label Oct 2, 2016
@mention-bot
Copy link

@DamienCassou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @khumba and @ryantrinkle to be potential reviewers.

@DamienCassou DamienCassou changed the base branch from master to release-16.09 October 2, 2016 06:01
@DamienCassou
Copy link
Contributor Author

The problem is that Emacs won't find the fonts I add that way. How can I make Emacs find fonts in the closure of its store path?

/cc @ttuegel @vcunat

@vcunat
Copy link
Member

vcunat commented Oct 2, 2016

@DamienCassou: it's possible to use something like pkgs.makeFontsConf and wrapProgram --set FONTCONFIG_FILE, though it will probably need some work for it to load the system default and only extend it by some font dirs (and even more to e.g. cover the case of user setting her own $FONTCONFIG_FILE).

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

@DamienCassou are you interested in pursuing this feature?

@DamienCassou
Copy link
Contributor Author

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DamienCassou @mention-bot @vcunat @grahamc