Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing to override url_type in render_template and rewrite_links methods. #2517

Merged
merged 1 commit into from Oct 2, 2016
Merged

Allowing to override url_type in render_template and rewrite_links methods. #2517

merged 1 commit into from Oct 2, 2016

Conversation

felixfontein
Copy link
Contributor

This allows a plugin to render a page which can be put at various URLs even if URL_TYPE in the site's config is set to rel_path. This can for example be used for creating 404 pages.

Kwpolska
Kwpolska approved these changes Oct 2, 2016
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will you publish the error pages plugin anywhere?

@felixfontein
Copy link
Contributor Author

As soon as I've implemented it, yes ;) I'm just in the process of checking what I need for it.

@Kwpolska Kwpolska merged commit 65d1832 into master Oct 2, 2016
@Kwpolska Kwpolska deleted the improving-link-rewrite-interface branch October 2, 2016 14:29
@felixfontein felixfontein mentioned this pull request Oct 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska