Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mirage/mirage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f6a0130e1885
Choose a base ref
...
head repository: mirage/mirage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 166b459eaa3a
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 13, 2016

  1. correct comment on listen and input operation in NETWORK and ETHIF

    Documentation claimed that `listen` and `input` would start asynchronous threads
    and return immediately.  This is incorrect; implementations don't return
    until `disconnect` has been called on the underlying interface.
    yomimono committed Oct 13, 2016
    Copy the full SHA
    a5848cf View commit details

Commits on Oct 14, 2016

  1. Merge pull request #619 from yomimono/listen-docstrings

    correct comment on `listen` and `input` operation in NETWORK and ETHIF
    yomimono authored Oct 14, 2016
    Copy the full SHA
    166b459 View commit details
Showing with 7 additions and 7 deletions.
  1. +7 −7 types/V1.mli
14 changes: 7 additions & 7 deletions types/V1.mli
Original file line number Diff line number Diff line change
@@ -332,9 +332,9 @@ module type NETWORK = sig

val listen: t -> (buffer -> unit io) -> unit io
(** [listen nf fn] is a blocking operation that calls [fn buf] with
every packet that is read from the interface. It returns as
soon as it has initialised, and the function can be stopped by
calling [disconnect] in the device layer. *)
every packet that is read from the interface.
The function can be stopped by calling [disconnect]
in the device layer. *)

val mac: t -> macaddr
(** [mac nf] is the MAC address of [nf]. *)
@@ -392,10 +392,10 @@ module type ETHIF = sig
(** [mac nf] is the MAC address of [nf]. *)

val input: arpv4:(buffer -> unit io) -> ipv4:(buffer -> unit io) -> ipv6:(buffer -> unit io) -> t -> buffer -> unit io
(** {b FIXME} [listen nf fn] is a blocking operation that calls [fn
buf] with every packet that is read from the interface. It
returns as soon as it has initialised, and the function can be
stopped by calling [disconnect] in the device layer. *)
(** [listen nf fn] is a blocking operation that calls [fn buf]
with every packet that is read from the interface.
The function can be stopped by calling [disconnect]
in the device layer. *)
end

(** {1 IP stack}