dunst service: init [wip, stalled] #19183

langston-barrett · 2016-10-03T04:10:20Z

Motivation for this change

Dunst is a notification server, it should be run all the time 💬

I'm having some trouble getting this working. When I run the command listed in the unit file, it works just fine (with correct settings). However, when I start the unit, it immediately fails without any log output. Could someone with a bit more experience with user units take a look? [edit: this seems to have been fixed by adding Type=dbus]

Bumped into #7326 while creating this... might have to get around to fixing that if I can.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

user level service
modelled on redshift

This reverts commit 2c2437bd2432537f3b6da3749e35d0cbb130c326.

* user level service * modelled on redshift

mention-bot · 2016-10-03T04:10:21Z

@siddharthist, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers.

joachifm · 2016-10-03T04:11:21Z

See also #11167

langston-barrett · 2016-10-03T04:19:11Z

I might go ahead and steal commits (if that's alright, @matthiasbeyer) from #11167, looks like it's a more complete rendering of the config file.

…vice

* add plain_text option * add a hint of documentation * remove unused uid, gid * make new service based on upstream, uses Type=dbus * don't require dmenu * add extraConfig option * add package option

langston-barrett · 2016-10-03T05:00:11Z

I think this just needs documentation and a little more testing. Will get back on it tomorrow!

langston-barrett · 2016-10-03T05:36:46Z

Looks like while the notification server is running, it isn't respecting our configuration. When I run the service manually using the command in the unit file, it does respect the configuration. Any ideas @matthiasbeyer? BTW, I'm happy to grant you commit access to my fork if you'd like to work collaboratively on polishing this up.

matthiasbeyer · 2016-10-03T07:36:47Z

Ah, you already did this! Awesome! Feel free to reuse any of my commits or revert, remove or squash them as you like!

matthiasbeyer · 2016-10-03T07:39:36Z

BTW, I'm happy to grant you commit access to my fork if you'd like to work collaboratively on polishing this up.

No, I'm happy with either sending you commits to cherry-pick or (what's more likely) let you do the stuff (helping where I can, but my semester starts tomorrow and I'm not sure I can help that much anyways).

groxxda · 2016-10-03T08:20:36Z

nixos/modules/services/desktops/dunst.nix

+      description = "Extra configuration to append to the config file.";
+    };
+
+    package = mkOption {


This isn't used and also the override mechanism should be enough.

@groxxda It is used, check the ExecStart. I modelled it after Redshift, where this is used.

Okay, but you don't use it for environment.systemPackages.
I still think this option is not necessary (same applies to redshift)

groxxda · 2016-10-03T08:21:23Z

nixos/modules/services/desktops/dunst.nix

+    environment.systemPackages = [ pkgs.dunst ];
+    systemd.user.services.dunst = {
+      description = "Dunst: lightweight and customizable notification daemon";
+      wantedBy = [ "default.target" ];


graphical.target seems like a better fit to me

I believe default.target is used for user services because there is no standard graphical.target, unlike for system services. Havent' checked if we provide such a thing, though.

oh your absolutely right. i didn't know this difference for user services. sorry for the trouble..

Unfortunately, this also makes it a little bit awkward to deal with user services for which a graphical target would make sense (i.e., what happens if user logs into console only).

groxxda · 2016-10-03T08:22:29Z

nixos/modules/services/desktops/dunst.nix

+        Restart = "always";
+        RestartSec = 3;
+      };
+      environment.DISPLAY = ":${toString (


I thought our x would already set this in the user env, but it may be DM specific

@groxxda This was also modelled after some other services.

groxxda · 2016-10-03T08:23:48Z

nixos/tests/dunst.nix

+            dunst = { config, pkgs, ... }: {
+                services.xserver.enable = true;
+                services.dunst.enable   = true;
+                environment.systemPackages = [ pkgs.libnotify ];


Does the service itself work without libnotify?

Yes, but not the test (which uses notify-send)

Okay thanks for the explanation 👍

markus1189 · 2016-11-22T20:02:51Z

So what is the current status of this pr? I would be very much interested ;)

langston-barrett · 2016-11-22T21:33:00Z

@markus1189 I'm not working on it anymore since I wasn't able to solve the mentioned issues.

matthiasbeyer · 2017-01-02T18:59:14Z

I would be interested as well. Can someone sum up what we need to do to get this into the repository?

Mic92 · 2017-01-03T01:13:53Z

@siddharthist can you squash everything into one commit at least for review?

matthiasbeyer · 2017-01-03T18:38:35Z

@Mic92 seems like @siddharthist does not have his nixpkgs repository anymore. I'm trying to investiate here.

matthiasbeyer · 2017-01-03T18:42:51Z

@Mic92 please have a look at the "add-dunst-service" branch in my nixpkgs fork. I squashed the commits from this PR and did some formatting of the source. I guess we can start with it, but I do not know how to test services, so it would be nice to get some help.

Mic92 · 2017-01-03T22:59:53Z

@matthiasbeyer I left some notes.

matthiasbeyer · 2017-01-04T08:44:09Z

@Mic92 yes I added what you've suggested. How can I test whether the service performs correctly? ("test" as in "try out" rather than in "test script").

langston-barrett · 2017-01-04T20:21:50Z

@Mic92 @matthiasbeyer I've been working considerably less on nixpkgs recently, my apologies for not getting back to you sooner. Essentially, I never got dunst starting reliably, and couldn't figure out what was wrong. You're obviously welcome to use anything I've done here if it's helpful.

langston-barrett · 2017-01-04T20:23:28Z

@matthiasbeyer I used to just check out the appropriate branch, and sudo nixos-rebuild switch. However, there is an issue with systemd user services and not getting updated correctly (say, if you make changes to the service definition and rebuild again), but I can't really remember what it is...

matthiasbeyer · 2017-01-30T09:32:50Z

I guess this one is stalled 😢

rycee · 2019-03-25T20:26:33Z

nixos/modules/services/desktops/dunst.nix

+
+  config = mkIf cfg.enable {
+    environment.systemPackages = [ pkgs.dunst ];
+    systemd.user.services.dunst = {


I'm curious, is this systemd service actually used for you? If you are in an X session with a running dunst, and run

$ systemctl --user status dunst.service

does it show as active or inactive? I suspect it will show inactive since this is something I've been having difficulties with in Home Manager.

c0bw3b · 2019-05-18T17:07:04Z

Closing this one.
There is more recent work in #58209

matthiasbeyer and others added 12 commits June 23, 2016 18:38

Add: dunst service

a913884

dunst service: Add test

f111cb7

fixup! Add: dunst service

050ebe1

[REVERT ME] Remove description, to test

bde08f6

Fix ExecStart script

fc47647

Variables instead of string building

974230a

Use a start-script

f58122a

Revert "Use a start-script"

844483e

This reverts commit 2c2437bd2432537f3b6da3749e35d0cbb130c326.

Set Type forking

d47200f

We want the graphical target

6175e4c

Start after the multi-user target

cb9be85

dunst service: init

a44a0ee

* user level service * modelled on redshift

langston-barrett added 2 commits October 3, 2016 04:36

Merge remote-tracking branch 'mattb/add-dunst-service' into dunst/ser…

af3235a

…vice

modify @matthiasbeyer's dunst service

696db7b

* add plain_text option * add a hint of documentation * remove unused uid, gid * make new service based on upstream, uses Type=dbus * don't require dmenu * add extraConfig option * add package option

langston-barrett mentioned this pull request Oct 3, 2016

[WIP] Add: dunst service #11167

Closed

groxxda reviewed Oct 3, 2016

View reviewed changes

langston-barrett added 3 commits October 3, 2016 19:10

dunst service: graphical.target > default.target

083a207

dunst service: remove package option

49d4264

dunst service: use default.target again

4ec2309

langston-barrett changed the title ~~dunst service: init [wip]~~ dunst service: init [wip, stalled] Jan 30, 2017

pSub added the 6.topic: nixos label May 5, 2017

joachifm added the 2.status: merge conflict label Feb 20, 2018

matthewbauer added the 2.status: work-in-progress label Mar 22, 2018

xaverdh mentioned this pull request Mar 24, 2019

Add dunst service #58209

Closed

10 tasks

rycee reviewed Mar 25, 2019

View reviewed changes

c0bw3b closed this May 18, 2019

c0bw3b added 2.status: merge conflict and removed 2.status: merge conflict 2.status: work-in-progress labels Feb 24, 2022

dunst service: init [wip, stalled] #19183

dunst service: init [wip, stalled] #19183

Conversation

langston-barrett commented Oct 3, 2016 • edited

Motivation for this change

Things done

mention-bot commented Oct 3, 2016

joachifm commented Oct 3, 2016

langston-barrett commented Oct 3, 2016 • edited

langston-barrett commented Oct 3, 2016

langston-barrett commented Oct 3, 2016

matthiasbeyer commented Oct 3, 2016

matthiasbeyer commented Oct 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

langston-barrett Oct 3, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markus1189 commented Nov 22, 2016

langston-barrett commented Nov 22, 2016

matthiasbeyer commented Jan 2, 2017

Mic92 commented Jan 3, 2017 • edited

matthiasbeyer commented Jan 3, 2017

matthiasbeyer commented Jan 3, 2017

Mic92 commented Jan 3, 2017

matthiasbeyer commented Jan 4, 2017

langston-barrett commented Jan 4, 2017

langston-barrett commented Jan 4, 2017

matthiasbeyer commented Jan 30, 2017

Choose a reason for hiding this comment

c0bw3b commented May 18, 2019

langston-barrett commented Oct 3, 2016 •

edited

langston-barrett commented Oct 3, 2016 •

edited

langston-barrett Oct 3, 2016 •

edited

Mic92 commented Jan 3, 2017 •

edited