Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 98918e40a5ca
Choose a base ref
...
head repository: jruby/jruby
compare: 43e9bb1a5be6
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 7, 2016

  1. Make all 1.8-era convert methods do 1.9 logic. 

    The 1.8 methods all blindly call respond_to? which breaks on any
BasicObject-based targets as in #4210. This patch modifies the
remaining 1.8 methods in TypeConverter to just call the 1.9 logic,
since there are no cases where MRI blindly calls respond_to? for
implicit conversions anymore.

Fixes #4210.
    @headius
    headius committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    d97bf85 View commit details
    Browse the repository at this point in the history

  2. Add specs for * and ** coercion of BasicObject types. 

    See #4210.
    @headius
    headius committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    43e9bb1 View commit details
    Browse the repository at this point in the history