Compiler: don't use byval in codegen #3474
Merged
+120
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asterite it fixed the issue for me on QEMU/ARM! |
|
@ysbaddaden Great! Thanks for testing this 🙇 |
|
Hey, thanks for investigating and fixing this 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the codegen never emit
byvalin function parameters except in C function calls because it seems that is required by the C ABI (or put another way, I tried not to usebyvaland it didn't work).@ysbaddaden You can try to apply this PR's diff on top of #3424 and then see if the new compiler can compile the Base64 spec and it passes on ARM (I didn't because I changed the pi's password in the office and back home I remembered I don't have a usb keyboard, so I'll be able to test this tomorrow)