Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the incorrect opscode mapping in f2i() #4224

Merged
merged 1 commit into from Oct 12, 2016
Merged

Fix the incorrect opscode mapping in f2i() #4224

merged 1 commit into from Oct 12, 2016

Conversation

sangmokh
Copy link
Contributor

  • f2i() should be mapped to F2I, instead of F2D. Note that F2I is a valid constant in org.objectweb.asm.Opcodes.
  • The incorrect mapping appears to be a copy-paste editing error from the above f2d() method.
  • Due to the error, when float-to-integer narrowing numeric conversion should occur, float-to-double widening numeric conversion was being done, which can have a negative impact on performance and memory usage.

@sangmokh
Fix the incorrect opscode mapping in f2i()
7e1c5e5 
 - f2i() should be mapped to F2I, instead of F2D.
 - The incorrect opscode mapping appears to be a copy-paste editing error.
 - Due to the error, when float-to-integer narrowing numeric conversion should occur,
   float-to-double widening numeric conversion was being done, which can have a
   negative impact on performance or memory usage.
@kares
Copy link
Member

kares commented Oct 12, 2016

najs ✂️ find!

@kares kares added this to the JRuby 9.1.6.0 milestone Oct 12, 2016
@enebo enebo merged commit 7c55b3b into jruby:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sangmokh @kares @enebo