Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c86bfd485ce
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7c55b3b1d4e6
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 12, 2016

  1. Fix the incorrect opscode mapping in f2i()

     - f2i() should be mapped to F2I, instead of F2D.
     - The incorrect opscode mapping appears to be a copy-paste editing error.
     - Due to the error, when float-to-integer narrowing numeric conversion should occur,
       float-to-double widening numeric conversion was being done, which can have a
       negative impact on performance or memory usage.
    sangmokh authored Oct 12, 2016

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7e1c5e5 View commit details
  2. Merge pull request #4224 from himosqui/patch-2

    Fix the incorrect opscode mapping in f2i()
    enebo authored Oct 12, 2016
    Copy the full SHA
    7c55b3b View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 core/src/main/java/org/jruby/compiler/impl/SkinnyMethodAdapter.java
Original file line number Diff line number Diff line change
@@ -799,7 +799,7 @@ public void f2d() {
}

public void f2i() {
getMethodVisitor().visitInsn(F2D);
getMethodVisitor().visitInsn(F2I);
}

public void f2l() {