Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 7c55b3b1d4e6
Choose a base ref
...
head repository: jruby/jruby
compare: 256042b90d1f
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Sep 30, 2016

  1. Inspect directly into a RubyString and avoid StringBuilder/char[].

    This should reduce the overhead of inspecting by avoiding the
    intermediate StringBuilder/char[] and subsequent conversion to
    byte[]. There are a few extra objects created along the way
    (java.lang.String.getBytes, RubyString for class name, etc) but
    overall memory use should reduce around 3x: a US-ASCII
    string would need 2x byte size in the StringBuilder, and the
    builder is still alive when we create the eventual byte[] for a
    total of 3x max memory use during inspect.
    
    Relates to #4127, but does not constitute a fix for memory issues
    there.
    headius committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    a40621d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8131146 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2016

  1. Merge pull request #4128 from headius/lighter_inspect

    Inspect directly into a RubyString and avoid StringBuilder/char[].
    enebo committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    256042b View commit details
    Browse the repository at this point in the history