Add File.chown and File.chmod #3358
Merged
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thank you! I think we can add typeof(File.chown("foo", uid: 100, gid: 200, follow_symlinks: true)) |
|
Aside: https://developer.apple.com/.../Articles/RaceConditions.html or google for: I work with several programs that run as root, so I'm pretty familiar with this detail ! |
ysbaddaden
force-pushed
the
std-file-chmod-chown
branch
from
aad268b to
d1af89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
File.chown(path, uid, gid)as well asFile.chmod(path, mode).I followed the POSIX definitions which made more sense in the context of File, instead of following the Ruby definitions that behave like the UNIX CLI tools:
chown uid, gid, *pathsandchmod mode, *paths. These last forms would be better into FileUtils (which is expected to behave like a shell).I didn't:
File#chownandFile#chmodcounterparts (targeting a file descriptor, not a path). I'm not sure they are that useful (I never neededfchownnorfchmod).chownbecause it required special privileges or a particular computer setup. I manually tested it behaved as documented instead.