Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cc21bfcfc05e
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 079c93ce0c56
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 21, 2016

  1. Copy the full SHA
    599cbc6 View commit details
  2. Copy the full SHA
    3e6582a View commit details
  3. Copy the full SHA
    079c93c View commit details
Showing with 2 additions and 8 deletions.
  1. +0 −3 mx.jruby/mx_jruby.py
  2. +2 −0 spec/truffle/tags/core/io/popen_tags.txt
  3. +0 −5 spec/truffle/truffle.mspec
3 changes: 0 additions & 3 deletions mx.jruby/mx_jruby.py
Original file line number Diff line number Diff line change
@@ -102,9 +102,6 @@ def get_source_path(self, resolve):
version = f.readline().strip()
return join(_suite.dir, 'core/target/jruby-core-' + version + '-shaded-sources.jar')

def extended_java_packages(self):
return []

class JRubyCoreBuildTask(mx.BuildTask):
def __str__(self):
return 'Building {} with Maven'.format(self.subject)
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/io/popen_tags.txt
Original file line number Diff line number Diff line change
@@ -19,4 +19,6 @@ fails:IO.popen with a leading Array argument accepts [env, command, arg1, arg2,
fails:IO.popen with a leading Array argument accepts '[env, command, arg1, arg2, ..., exec options], mode'
fails:IO.popen with a leading Array argument accepts '[env, command, arg1, arg2, ..., exec options], mode, IO options'
fails:IO.popen with a leading Array argument accepts '[env, command, arg1, arg2, ...], mode, IO + exec options'
fails:IO.popen raises IOError when writing a read-only pipe
fails:IO.popen reads and writes a read/write pipe
slow:IO.popen sees an infinitely looping subprocess exit when read pipe is closed
5 changes: 0 additions & 5 deletions spec/truffle/truffle.mspec
Original file line number Diff line number Diff line change
@@ -37,11 +37,6 @@ class MSpecScript

set :core, [
"spec/ruby/core",

# Troublesome - they do work, but sometimes fail, sometimes timeout
"^spec/ruby/core/io/io_spec.rb",
"^spec/ruby/core/io/popen_spec.rb",
"^spec/ruby/core/io/pipe_spec.rb"
]

set :library, [