Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation for OAuth2 #3453

Merged
merged 2 commits into from
Oct 22, 2016
Merged

Fixed documentation for OAuth2 #3453

merged 2 commits into from
Oct 22, 2016
+3 −2

Conversation

watzon
Copy link
Contributor

@watzon watzon commented Oct 21, 2016 •
edited
Loading

Fixed documentation for OAuth2 #3452

Verified

This commit was signed with the committer’s verified signature.
headius Charles Oliver Nutter
GPG key ID: 8E26FF248BC7AEAD
Verified
Learn about vigilant mode
0cec8b7
@watzon watzon changed the title Fixed documentation for OAuth2 #3452 Fixed documentation for OAuth2 Oct 21, 2016
@lbguilherme
Copy link
Contributor

As a related suggestion: Maybe we could change the interface to take a Time::Span as argument instead of plain Int. This way it is possible to write:

OAuth2::AccessToken::Bearer.new("some_access_token", 48.hours)

@asterite
Copy link
Member

Thank you!

@asterite asterite merged commit 66f6970 into crystal-lang:master Oct 22, 2016
@watzon
Copy link
Contributor Author

watzon commented Oct 22, 2016

@asterite I like @lbguilherme's idea. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@watzon @lbguilherme @asterite