Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-8974: Add isni-list to artist & label. #7

Merged
merged 4 commits into from Jul 31, 2018
Merged

MBS-8974: Add isni-list to artist & label. #7

merged 4 commits into from Jul 31, 2018

Conversation

Zastai
Copy link
Contributor

@Zastai Zastai commented Oct 23, 2016

Think this is right; Wikipedia lists ISNIs as 16-digit.

@Zastai
Copy link
Contributor Author

Zastai commented Oct 23, 2016

Looks like this isn't quite correct yet. The last digit is a check digit modulo 11, so it can be X for 10. Will adjust it.

@gentlecat gentlecat requested a review from mwiencek June 6, 2017 14:47
@gentlecat
Copy link

Looks like there are some conflicts now.

@Zastai
Copy link
Contributor Author

Zastai commented Jun 8, 2017

Will have a look over the weekend. Shouldn't be hard to resolve.

@yvanzo yvanzo removed the request for review from mwiencek July 31, 2018 17:56
yvanzo
yvanzo approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zastai for the patch.
I just rebased it on master.

@yvanzo yvanzo merged commit 8eed188 into metabrainz:master Jul 31, 2018
@yvanzo yvanzo mentioned this pull request Jul 31, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Zastai @gentlecat @yvanzo