You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Under JRuby, these two examples result in 1582-10-20 and 1582-10-15, respectively. This causes errors in at least two rails/activesupport tests:
1) Failure:
DateExtCalculationsTest#test_next_year_in_calendar_reform [/Users/headius/projects/rails/activesupport/test/core_ext/date_ext_test.rb:138]:
Expected: Thu, 04 Oct 1582
Actual: Wed, 20 Oct 1582
2) Failure:
DateExtCalculationsTest#test_advance_in_calendar_reform [/Users/headius/projects/rails/activesupport/test/core_ext/date_ext_test.rb:166]:
Expected: Thu, 04 Oct 1582
Actual: Fri, 15 Oct 1582
I looked up when these tests were added, and it appears they were added to test a monkey-patch applied to 1.8 for a date reform fix only in 1.9 and higher. Out implementation of date does not appear to match.
The text was updated successfully, but these errors were encountered:
Environment
JRuby master (pre-9.1.6.0)
Rails master (pre-5.1)
Expected Behavior
Date advancing should honor the 1582 time reformation in the following examples:
Actual Behavior
Under JRuby, these two examples result in
1582-10-20
and1582-10-15
, respectively. This causes errors in at least two rails/activesupport tests:I looked up when these tests were added, and it appears they were added to test a monkey-patch applied to 1.8 for a date reform fix only in 1.9 and higher. Out implementation of date does not appear to match.
The text was updated successfully, but these errors were encountered: