Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opa: update #19806

Merged
merged 1 commit into from Nov 26, 2016
Merged

opa: update #19806

merged 1 commit into from Nov 26, 2016

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 23, 2016

Motivation for this change

See #19665.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @edolstra and @7c6f434c to be potential reviewers.

@NeQuissimus
Copy link
Member

This does not build for me:

make flags: SHELL=/nix/store/vjm2a2zviphmxiz7j1ghl2dcw6f401bl-bash-4.3-p46/bin/bash    
yes
checking for gcc option to accept ISO C89... ./z_pp.pl x86_64
/nix/store/vjm2a2zviphmxiz7j1ghl2dcw6f401bl-bash-4.3-p46/bin/bash: ./z_pp.pl: /usr/bin/env: bad interpreter: No such file or directory
project.mak:137: depend: No such file or directory
make: *** [project.mak:110: z.ml] Error 126
builder for ‘/nix/store/5fyn1aprwqlx7gdmd3w8hf6r978s5kcv-zarith-1.4.1.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/gi9v1jagwrpj6g79bbb0sal1h372k26i-cryptokit-1.11.drv’: 1 dependencies couldn't be built
killing process 24633
killing process 24576
cannot build derivation ‘/nix/store/hy8rvyybnh8fk4bz660akqhv43dq25z6-opa-4310.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/hy8rvyybnh8fk4bz660akqhv43dq25z6-opa-4310.drv’ failed
exit 100

@grahamc
Copy link
Member

grahamc commented Oct 25, 2016

Weird, @NeQuissimus -- it just built for me?

@NeQuissimus
Copy link
Member

Strange, since it said something about /usr/bin/env, I tried building from Bash instead of Zsh (not that that should matter...). It also says it cannot find depend, no idea if that is supposed to be a tool.

I tried it multiple times with the same result every time.

@grahamc
Copy link
Member

grahamc commented Oct 25, 2016

Ah, yep, you're right. When I was building I built it against the channel version.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 25, 2016

Thanks for the report. It appears that the (recently updated) zarith package would not build when /usr/bin/env is not available. I’ve just added a commit that should address this issue.

@NeQuissimus
Copy link
Member

It gets a lot further now but it still does not build:

/nix/store/w1f0labnmxmkdaljs4v2rsbvh43r3264-ocaml-4.02.3/bin/ocamlc.opt -c -g -warn-error A -w L -w Z -I ocamllib/libbase -I compiler/buildinfos -I compiler/compilerlib -I compiler/libqmlcompil -I compiler/libtrx -I compiler/opacapi -I compiler/passlib -I compiler/opalang -I compiler/opalang/classic_syntax -I compiler/opalang/js_syntax -I tools -I ocamllib -I lib -I compiler -I tools/build -o compiler/opalang/classic_syntax/opa_classic_parser.cmo compiler/opalang/classic_syntax/opa_classic_parser.ml
/nix/store/w1f0labnmxmkdaljs4v2rsbvh43r3264-ocaml-4.02.3/bin/ocamlc.opt -c -g -warn-error A -w L -w Z -I ocamllib/libbase -I compiler/buildinfos -I compiler/compilerlib -I compiler/libqmlcompil -I compiler/libtrx -I compiler/opacapi -I compiler/passlib -I compiler/opalang -I compiler/opalang/classic_syntax -I compiler/opalang/js_syntax -I tools -I ocamllib -I lib -I compiler -I tools/build -o compiler/opalang/classic_syntax/parser_utils.cmo compiler/opalang/classic_syntax/parser_utils.ml
/nix/store/w1f0labnmxmkdaljs4v2rsbvh43r3264-ocaml-4.02.3/bin/ocamlc.opt -c -g -warn-error A -w L -w Z -I ocamllib/libbase -I compiler/buildinfos -I compiler/compilerlib -I compiler/libqmlcompil -I compiler/libtrx -I compiler/opacapi -I compiler/passlib -I compiler/opalang -I compiler/opalang/classic_syntax -I compiler/opalang/js_syntax -I tools -I ocamllib -I lib -I compiler -I tools/build -o compiler/opalang/js_syntax/opa_js_parser.cmo compiler/opalang/js_syntax/opa_js_parser.ml
/nix/store/w1f0labnmxmkdaljs4v2rsbvh43r3264-ocaml-4.02.3/bin/ocamlc.opt -c -g -warn-error A -w L -w Z -I ocamllib/libbase -I compiler/compilerlib -I compiler/libqmlcompil -I compiler/opacapi -I compiler/passlib -pp 'perl /tmp/nix-build-opa-4310.drv-0/opalang-a13d45af30bc955c40c4b320353fb21e4ecacbc5-src/tools/utils/ppdebug.pl' -I compiler/opalang -I compiler/opalang/classic_syntax -I compiler/opalang/js_syntax -I tools -I ocamllib -I lib -I compiler -I tools/build -o compiler/opalang/opaMapToIdent.cmo compiler/opalang/opaMapToIdent.ml
+ /nix/store/w1f0labnmxmkdaljs4v2rsbvh43r3264-ocaml-4.02.3/bin/ocamlc.opt -c -g -warn-error A -w L -w Z -I ocamllib/libbase -I compiler/compilerlib -I compiler/libqmlcompil -I compiler/passlib -I compiler/opalang -I compiler/opalang/classic_syntax -I compiler/opalang/js_syntax -I tools -I ocamllib -I lib -I compiler -I tools/build -o compiler/opalang/opaPrint.cmo compiler/opalang/opaPrint.ml
Command got signal -10.
make: *** [Makefile:44: node] Error 11
builder for ‘/nix/store/wvi9i9m9jmq2qakvjmd3pij6s2viw3mq-opa-4310.drv’ failed with exit code 2
error: build of ‘/nix/store/wvi9i9m9jmq2qakvjmd3pij6s2viw3mq-opa-4310.drv’ failed
exit 100

@vbgl
Copy link
Contributor Author

vbgl commented Oct 26, 2016

What is signal -10? Is this the OCaml compiler that seg-faults? Strange… Can you give some details about your architecture etc?

@NeQuissimus
Copy link
Member 

▶ cat /proc/cpuinfo | grep 'model name' -B 4 | grep -v processor | sort | uniq
--
cpu family      : 6
model           : 78
model name      : Intel(R) Core(TM) m3-6Y30 CPU @ 0.90GHz
vendor_id       : GenuineIntel

▶ uname -a
Linux nixus 4.8.4 #1-NixOS SMP Sat Oct 22 10:41:00 UTC 2016 x86_64 GNU/Linux                                                                                                                                                                                   
▶ nixos-version
17.03pre94330.d333ec5 (Gorilla)

@vbgl
Copy link
Contributor Author

vbgl commented Nov 17, 2016

I can’t reproduce this build failure. I think that this is not a packaging issue.

@7c6f434c
Copy link
Member

Maybe memory amount? Works for me. And the previous version was marked broken anyway, so I am for merging

@7c6f434c 7c6f434c merged commit 81667f3 into NixOS:master Nov 26, 2016
@vbgl vbgl deleted the opa-4310 branch December 22, 2016 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 9.needs: reporter feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbgl @mention-bot @NeQuissimus @grahamc @7c6f434c