Passing url_type into template context. #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
approved these changes
Oct 23, 2016
| @@ -1306,6 +1306,7 @@ def render_template(self, template_name, output_name, context, url_type=None): | |||
| for k in self._GLOBAL_CONTEXT_TRANSLATABLE: | |||
| local_context[k] = local_context[k](local_context['lang']) | |||
| local_context['is_rtl'] = local_context['lang'] in LEGAL_VALUES['RTL_LANGUAGES'] | |||
| local_context['url_type'] = self.config['URL_TYPE'] if url_type is None else url_type | |||
There was a problem hiding this comment.
Now that we’re doing all this, perhaps we could pass url_type into this function from callers?
There was a problem hiding this comment.
Why should callers pass the argument twice (both into context and to render_template)? After all this value is used in the default base theme in essentially every template.
There was a problem hiding this comment.
I couldn't find a reason why anyone calling this function does NOT want to have url_type in context (except that it causes all pages to recompile, that is).
There was a problem hiding this comment.
Ah, generic_ don’t use url_type themselves. Feel free to merge.
There was a problem hiding this comment.
Ok, thanks, I'll merge then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modifies base theme to use that when calling
url_replacer. This allows to fix the Nikola core part of getnikola/plugins#176.