New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: change default to python3
#19626
Conversation
@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus, @peti and @micxjo to be potential reviewers. |
http://hydra.nixos.org/jobset/nixpkgs/python3 builds python packages only, but I guess we should rebuild the whole nixpkgs? I'll change to that. |
Done. |
217203f
to
5b608b9
Compare
84f9b05
to
9e4df40
Compare
Failures relative to staging: I think I've fixed about half of those by now. |
latest evaluation @domenkozar could we merge this into staging? There are still some important failures, but as far as I can see no more rebuilds. Then on staging we can fix the final issues that prevent merging into master. |
Two issues merging this:
|
Indeed, there's a bit more failures http://hydra.nixos.org/eval/1297698?compare=1297372 |
There's also the list of errors to consider. This list will include packages that could not be build because a Python dependency is disabled. That's a looooong list. |
Does the LLVM stuff still work? That's the main thing I care about for Darwin purposes. |
ee7e7ea
to
a312b6c
Compare
I've merged into staging everything except the actual switch to Python 3. |
@copumpkin all llvm except for 3.4 were building fine. correction: llvm 3.7 needed python 2 because of a bytes - str issue. |
Some packages are not available for Python 3. Therefore, any package that depends on this one should use Python 2.
|
dad6032
to
92b6b52
Compare
I tried merging this into staging and building the darwin stdenv and I didn't notice any difference during the bootstrap. Is LLVM pulling in python2 explicitly? |
540201a
to
bcf8ef6
Compare
3118143
to
a3b13a0
Compare
My system now runs on this branch, and I haven't encountered any issues so far. Judging from the tests I think there's only one issue remaining, and that would be fixing kde 4. Aside from that there's a bunch of lesser important packages that need to be fixed but I'll leave that for the maintainers. |
@@ -1,7 +1,7 @@ | |||
{ stdenv, fetchurl, cmake, libxml2, libxslt, python, sphinx, qt4 }: | |||
|
|||
stdenv.mkDerivation { | |||
name = "${python.libPrefix}-pyside-apiextractor-0.10.10"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder to self: this isn't correct yet.
0bec21a
to
81dc67c
Compare
0a4aadb
to
8aa62a3
Compare
If we want to have Python 3.5 as default some fixes are going to be needed. If I recall correctly Python 3 builds or packages are not yet deterministic. I won't have much time to work on this or Nixpkgs in general the coming months (final phase of PhD). cc release manager @globin |
Do you see this being ready for the branch-off at the end of February? |
@globin unless someone else picks it up, no. I won't have any time to work on this. Migrating the final packages to Python 3 (or letting them remain at 2) shouldn't be too much work I think. |
I'll include a link to this PR in the timeline announcement, hoping someone will pick this up. |
e98efc2
to
9fbe535
Compare
Even though Python 3 is now the default interpreter, we would like to have `/bin/python` refer to 2 in case both 2 and 3 are installed in one profile. This automatically applies to python27.buildEnv as well since buildEnv inherits the meta from Python.
As was discussed on the mailing list some are against simply staging |
Motivation for this change
#18185
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)