Don't dup every element in Enumerator#drop (9K) #4225
Merged
+23
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4218 in JRuby 9K.
In 06f0441 (JRUBY-6892)
Enumerable#drop
was changed to call#dup
on every element that ended up in the result, but that might not work. Not all objects correctly implement#dup
, or are even allocatable.#take
was not changed, and looking at the differences between#take
and#drop
the only thing that stood out was that the signature of the #each call was different. Changing fromSignature.NO_ARGUMENTS
toSignature.ONE_REQUIRED
make the issue that 06f0441 tried to fix go away.