Merge pull request #2541 from getnikola/plugin-deps

Plugin deps (Fix #2533)
getnikola · Oct 20, 2016 · 5ee1a3a · 5ee1a3a
2 parents 3b0c817 + bd3b8a2
commit 5ee1a3a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -9,6 +9,7 @@ Bugfixes
 Features
 --------
 
+* Plugins can depend on other plugins being installed (Issue #2533)
 * The destination folder in ``POSTS`` and ``PAGES`` can now be
   translated (Issue #2116)
 * Pass ``post`` object and ``lang`` to post compilers (Issue #2531)

diff --git a/nikola/plugins/command/plugin.py b/nikola/plugins/command/plugin.py
@@ -265,6 +265,7 @@ def do_install(self, url, name, show_install_notes=True):
                       'package manager.')
             else:
                 LOGGER.info('Dependency installation succeeded.')
+
         reqnpypath = os.path.join(dest_path, 'requirements-nonpy.txt')
         if os.path.exists(reqnpypath):
             LOGGER.notice('This plugin has third-party '
@@ -280,6 +281,25 @@ def do_install(self, url, name, show_install_notes=True):
 
             print('You have to install those yourself or through a package '
                   'manager.')
+
+        req_plug_path = os.path.join(dest_path, 'requirements-plugins.txt')
+        if os.path.exists(req_plug_path):
+            LOGGER.notice('This plugin requires other Nikola plugins.')
+            LOGGER.info('Installing plugins using Nikola...')
+            print('Contents of the requirements-nonpy.txt file:\n')
+            try:
+                with io.open(req_plug_path, 'r', encoding='utf-8') as inf:
+                    for plugname in inf.readlines():
+                        self.do_install(url, plugname, show_install_notes)
+            except subprocess.CalledProcessError:
+                LOGGER.error('Could not install a plugin.')
+                print('Contents of the requirements-plugins.txt file:\n')
+                with io.open(req_plug_path, 'r', encoding='utf-8') as fh:
+                    print(utils.indent(fh.read(), 4 * ' '))
+                print('You have to install those yourself manually.')
+            else:
+                LOGGER.info('Dependency installation succeeded.')
+
         confpypath = os.path.join(dest_path, 'conf.py.sample')
         if os.path.exists(confpypath) and show_install_notes:
             LOGGER.notice('This plugin has a sample config file.  Integrate it with yours in order to make this plugin work!')