linuxPackages.ati_drivers_x11: patch for kernel 4.7+ #19810
Conversation
|
@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @heydojo, @MarcWeber and @edwtjo to be potential reviewers. |
| ./patches/kernel-4.6-page_cache_release-put_page.patch ]; | ||
| ./patches/kernel-4.6-page_cache_release-put_page.patch ] | ||
| ++ optionals ( kernel != null && | ||
| (builtins.compareVersions kernel.version "4.7") >= 0 ) |
There was a problem hiding this comment.
Could we not use versionAtLeast and/or versionOlder instead? Seems cleaner
There was a problem hiding this comment.
I thought I looked for something like that when I did the 4.6 patches and didn't find it. I'll try to revise tonight.
Hey, Matt! Thank you so much for the contribution, and keeping these up to date. I know how frustrating it is to find out after the fact that kernel updates have broken your drivers, I've had the same experience with the nvidia drivers myself. If you would like, you could add yourself as a maintainer to the package, and when we get a kernel update you'll get an email when the package fails. Then you woudl know before you try and upgrade, and give you a chance to patch it sooner. This would be a huge help if you're willing. Thank you for the patch! |
uses patch from commit 392aac08 in https://aur.archlinux.org/packages/catalyst/
|
its very unfortunate, but i fear #19841 makes this one invalid |
|
I think kernel 4.8, 4.9, etc. will maintain the same API changes that broken with the 4.7 release, though, no? We are doing That said, I haven't tested with kernel 4.8. I can do that if you'd like before merging. |
|
Hey @jerith666, sorry for being behind on this. If you could test it with 4.8 (if you'd go so far as building your system and booting to it, that would be ideal) I'd merge it ASAP. |
|
Sorry, I'm behind on it too! I actually did pick it back up last night and got so far as to build it successfully with kernel 4.8, but I haven't booted it yet. Hoping to do that tonight (while waiting for election returns to roll in ... 😄 ). |
|
I can now confirm that this works with kernel 4.8.4 in recent |
fpletz
changed the title
Motivation for this change
Yet another case of binary ATI drivers lagging behind kernel API changes.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)uses patch from commit 392aac08 in https://aur.archlinux.org/packages/catalyst/
Confirmed working with minecraft and starcraft 2 locally.