XTerm: fix app-defaults, fixes menu options #19818
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KoviRobi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @edolstra and @vrthra to be potential reviewers. |
Mic92
reviewed
Oct 24, 2016
| @@ -30,6 +30,7 @@ stdenv.mkDerivation rec { | |||
| "--enable-luit" | |||
| "--enable-mini-luit" | |||
| "--with-tty-group=tty" | |||
| "--with-app-defaults=$(out)/lib/X11/app-defaults" | |||
There was a problem hiding this comment.
So this option is not respected, or we do have to set XAPPLRESDIR below?
There was a problem hiding this comment.
This is just the installation directory, the XAPPLRESDIR is for X11 code, not for XTerm code. I think this is not necessary, strictly speaking, but I thought explicit is better because autoconf should make it /usr/X11/lib/app-defaults or some other system wide directory, but doesn't for simplicity. But who knows, that might change at which point this line might be necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
XTerm menu labels were missing, and menu items did nothing.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)