Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2531 — pass post and lang to compilers #2532

Merged
merged 8 commits into from Oct 15, 2016
Merged

Fix #2531 — pass post and lang to compilers #2532

merged 8 commits into from Oct 15, 2016

Conversation

Kwpolska
Copy link
Member

This is #2531. There isn’t anything else we could post to this function, so hopefully we won’t have to do real_compile next time.

cc @felixfontein, reviews welcome.

felixfontein
felixfontein approved these changes Oct 14, 2016
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No idea about the failing tests, though...

@Kwpolska
Copy link
Member Author

This is so stupid. Apparently, is_one_file can make things break if set incorrectly (perhaps due to metadata splitting). I’ll fix it and merge.

@felixfontein
Copy link
Contributor

Why not fix the test instead of (again) having the compilers compile signature disagree with the signature in PageCompiler?

@Kwpolska
Matching signatures for compile
ce2f510 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

Or we can make the PageCompiler signature match.

And the problem is not really in the test. is_two_file set to False means some extra manipulation which should not be the default.

@Kwpolska Kwpolska merged commit f5d42cf into master Oct 15, 2016
@Kwpolska Kwpolska deleted the new-compile-function branch October 15, 2016 07:33
@felixfontein felixfontein mentioned this pull request Oct 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kwpolska @felixfontein