Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 79fd722e45b7
Choose a base ref
...
head repository: jruby/jruby
compare: c848f280e4b6
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Sep 30, 2016

  1. Fix JI test expecting NativeException-wrapping from constructors. 

    In 5d057d2 I modified behavior for Java constructors by
re-raising rather than wrapping in NativeException any exceptions
they throw. The NativeException behavior was a relic of a bygone
era, and normal Java methods have not thrown it for several years.
This commit fixes a test that still expected all constructor-
originated exceptions to be wrapped in NativeException; it now
expects the true exception to be raised and asserts accordingly.
    @headius
    headius committed Sep 30, 2016
    4 Configuration menu
    Copy the full SHA
    3ee8ac9 View commit details
    Browse the repository at this point in the history

  2. Re-expose and deprecate RubyException.message. 

    This field is still used by Psych (ruby/psych##292). I re-exposed
it for now but modified all of JRuby to use the accessors so we
aren't getting deprecation warnings. Once the gem is out we can
attempt to hide the field again.
    @headius
    headius committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    c848f28 View commit details
    Browse the repository at this point in the history