Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prime? openssl error in 9.1.5.0 #4193

Closed
jzakiya opened this issue Sep 30, 2016 · 5 comments
Closed

prime? openssl error in 9.1.5.0 #4193

jzakiya opened this issue Sep 30, 2016 · 5 comments
Labels
needs tests openssl
Milestone
JRuby 9.1.6.0

Comments

@jzakiya
Copy link

jzakiya commented Sep 30, 2016

Environment

$ jruby -v
jruby 9.1.5.0 (2.3.1) 2016-09-07 036ce39 Java HotSpot(TM) 64-Bit Server VM 25.102-b14 on 1.8.0_102-b14 +jit [linux-x86_64]

$ uname -a
Linux localhost 4.7.5-pclos1 #1 SMP Sun Sep 25 17:05:47 CDT 2016 x86_64 x86_64 x86_64 GNU/Linux

Expected Behavior

> require 'openssl'
> 5.to_bn.prime?
 => true
> -5.to_bn.prime?
 => false

Actual Behavior

> require 'openssl'
> 5.to_bn.prime?
 => true
> -5.to_bn.prime?     
 => true                  -- should be false, this is an error for all negative primes
@headius
Copy link
Member

headius commented Sep 30, 2016

Seems legit. Normally I'd ask you to re-file at jruby/jruby-openssl but this seems pretty trivial.

@headius
Copy link
Member

headius commented Sep 30, 2016

@kares @mkristian Any reason we couldn't put out a jruby-openssl release right now?

@headius headius mentioned this issue Sep 30, 2016
Closed
@headius headius added this to the JRuby 9.1.6.0 milestone Sep 30, 2016
@headius
Copy link
Member

headius commented Sep 30, 2016

This is fixed in jruby-openssl and just needs releases.

@headius
Copy link
Member

headius commented Sep 30, 2016

Oh...we need tests for this. Want to PR something quick for jruby/jruby-openssl?

@kares
Copy link
Member

kares commented Nov 10, 2016

this actually isn't in 9.1.6.0 unless gem install jruby-openssl, updated gem (0.9.18) should be in 9.1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests openssl
Projects
None yet
Milestone
JRuby 9.1.6.0
Development

No branches or pull requests
3 participants
@headius @kares @jzakiya