Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 4b3cf110ae4d
Choose a base ref
...
head repository: jruby/jruby
compare: 192ca1833188
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 20, 2016

  1. Add assertion to catch potential future gotchas

    @subbuss
    subbuss committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    4253b8e View commit details
    Browse the repository at this point in the history

  2. Be more precise about identifying undefined lvars in nested scopes 

    I was checking for lvar.getScopeDepth() < expectedScopeDepth
instead of lvar.getScopeDepth() == expectedScopeDepth.

This caused unexpected initializations to be added in multi-level
nesting scenarios like this:

def foo
  x = 1
  loop do
    loop do
      ...
      p x
      ...
    end
  end
end

The old code was trying add an initialize of 'x' in the outer loop
which was the bug.
    @subbuss
    subbuss committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    192ca18 View commit details
    Browse the repository at this point in the history