Allows running spec within Docker container #3441
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this!! ❤️ I think we should include all dependencies that some part of the standard library depends on. So far I think it's And I'd do it to for the release container. |
|
@asterite I had The change is only for I'm adding now the change for |
`crystal spec` commands now supports JUnit XML output, which requires libxml2 to be installed. With current defaults, the command fails due missing `libxml2-dev` dependencies in the image. This change ensures `libxml2-dev` is installed along the other dependencies so can be used for both building executables and running specs. Also includes `libyaml-dev` so any attempt to using `yaml` works out of the box.
|
Thank you!! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crystal speccommands now supports JUnit XML output, which requires libxml2 to be installed.With current defaults, the command fails due missing
libxml2-devdependencies in the image.This change ensures
libxml2-devis installed along the other dependencies so can be used for both building executables and running specs.Without this change, attempt to use official docker image fails with the following:
But with this change:
I'm still not sure if including xml is desired for the release container, but considering might others need XML support during compilation too perhaps is not a bad idea?
Thank you ❤️ ❤️ ❤️ ❤️