-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Socket.socketpair to return Socket instances #4204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality changes look fine, but @eregon needs to weigh in on the ruby/spec change.
|
||
s1.should be_an_instance_of(Socket) | ||
s2.should be_an_instance_of(Socket) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK to add specs directly here, even if the commits contains other changes. The advantages is it's tested directly against jruby and we don't need to wait for a spec merge.
However I prefer if the specs are in a commit alone as usually it means I don't need to edit the commit message 😃
s1, s2 = Socket.public_send(@method, :UNIX, :STREAM) | ||
|
||
s1.should be_an_instance_of(Socket) | ||
s2.should be_an_instance_of(Socket) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opened file descriptors should be closed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
b0fffa7
to
88f82fd
Compare
88f82fd
to
354b35b
Compare
Done. |
sock2 was left uninitialized
354b35b
to
303e5d8
Compare
No description provided.