Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: http-party/node-http-proxy
base: f5217d6c20c1
Choose a base ref
...
head repository: http-party/node-http-proxy
compare: d0f1dfeb8277
Choose a head ref
  • 6 commits
  • 4 files changed
  • 4 contributors

Commits on Oct 22, 2016

  1. Fix browserification 

    Browserify fails to resolve the "./http-proxy/" as "./http-proxy/index.js" but as "./http-proxy.js" (so nothing works)
Beeing explicit here does not cost much for http-proxy, yet it's intrinsically complicated for browserify to fix (as trailing slash might be used as a pollyfill shim for native/non-natives addons i.e.  require('url/') vs require('url') )
    @131 @jcrugzz
    131 authored and jcrugzz committed Oct 22, 2016
    Copy the full SHA
    8eddf45 View commit details
    Browse the repository at this point in the history

  2. With a comment

    @131 @jcrugzz
    131 authored and jcrugzz committed Oct 22, 2016
    Copy the full SHA
    fbc2668 View commit details
    Browse the repository at this point in the history

  3. Do not rely on func.name (no scope)

    @131 @jcrugzz
    131 authored and jcrugzz committed Oct 22, 2016
    Copy the full SHA
    61c2889 View commit details
    Browse the repository at this point in the history

  4. Do not rely on func.name (no scope)

    @131 @jcrugzz
    131 authored and jcrugzz committed Oct 22, 2016
    Copy the full SHA
    d48f67e View commit details
    Browse the repository at this point in the history

  5. Expose full callback names

    @131 @jcrugzz
    131 authored and jcrugzz committed Oct 22, 2016
    Copy the full SHA
    220f5fb View commit details
    Browse the repository at this point in the history

  6. [fix] style nits

    @jcrugzz
    jcrugzz committed Oct 22, 2016
    Copy the full SHA
    d0f1dfe View commit details
    Browse the repository at this point in the history