-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates doc styles for a slightly more modern appeal #3456
Conversation
- updates to more modern font-stack. - optimizes margin for headers and changes color to lighter shade of gray. - adds box around h1. - adds border under h2s. - adds bottom padding to types list. - changes style for search input and adds subtle. shadowing on focus - adds monospace fonts to signatures. - decreases top margin for summary paragraphs. - adds light border to pre elements.
box-shadow: 0px 5px 6px rgba(0,0,0,.5); | ||
} | ||
|
||
#types-list input::-webkit-input-placeholder { /* Chrome/Opera/Safari */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you group the definitions instead of repeating them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually not possible. If one browser see the group with a metaclass it doesn't recognize, it will drop the whole group. So this would end up being ignored on all browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysbaddaden yeah, what @lbguilherme said. Its not possible in this scenario because these are not prefixes. If you know a more succinct way to change an input placeholder I will implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could remove the support for firefox 18-. There probably aren't many people on that older version anymore (from 2012-2013).
@samueleaton Nice work!! I think I like it (unfortunately I have programmer eyes). It does seem to be easier on the eye, and look more professional. |
@asterite well, it's intended to developers, so your eyes are good :) |
Let's merge this, it does look better. @samueleaton Thank you for this! ❤️ |
to lighter shade of gray.
h1
.h2
s.shadowing on focus.
pre
elements.Before

After

Before

After
