Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates doc styles for a slightly more modern appeal #3456

Merged
merged 3 commits into from
Oct 25, 2016

Conversation

samueleaton
Copy link
Contributor

@samueleaton samueleaton commented Oct 22, 2016

  • updates to more modern font-stack.
  • optimizes margin for headers and changes color
    to lighter shade of gray.
  • adds box around h1.
  • adds border under h2s.
  • adds bottom padding to types list.
  • adds slight color transition on hover for types-list links and code signatures
  • changes style for search input and adds subtle
    shadowing on focus.
  • adds monospace fonts to signatures.
  • decreases top margin for summary paragraphs.
  • adds light border to pre elements.

Before
array-before

After
array-after




Before
array-instance-methods-before

After
array-instance-methods-after

Sam Eaton added 2 commits October 21, 2016 21:24

Verified

This commit was signed with the committer’s verified signature.
headius Charles Oliver Nutter
- updates to more modern font-stack.
- optimizes margin for headers and changes color
  to lighter shade of gray.
- adds box around h1.
- adds border under h2s.
- adds bottom padding to types list.
- changes style for search input and adds subtle.
  shadowing on focus
- adds monospace fonts to signatures.
- decreases top margin for summary paragraphs.
- adds light border to pre elements.
box-shadow: 0px 5px 6px rgba(0,0,0,.5);
}

#types-list input::-webkit-input-placeholder { /* Chrome/Opera/Safari */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you group the definitions instead of repeating them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually not possible. If one browser see the group with a metaclass it doesn't recognize, it will drop the whole group. So this would end up being ignored on all browsers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysbaddaden yeah, what @lbguilherme said. Its not possible in this scenario because these are not prefixes. If you know a more succinct way to change an input placeholder I will implement it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could remove the support for firefox 18-. There probably aren't many people on that older version anymore (from 2012-2013).

@asterite
Copy link
Member

@samueleaton Nice work!! I think I like it (unfortunately I have programmer eyes). It does seem to be easier on the eye, and look more professional.

@ysbaddaden
Copy link
Contributor

@asterite well, it's intended to developers, so your eyes are good :)

@samueleaton
Copy link
Contributor Author

Some other things not highlighted in other screenshots.

padding-and-shadowing

@asterite
Copy link
Member

Let's merge this, it does look better. @samueleaton Thank you for this! ❤️

@asterite asterite merged commit 06639e6 into crystal-lang:master Oct 25, 2016
@asterite asterite added this to the 0.20.0 milestone Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants