[Truffle] Global replace anonymous classes with lambdas. #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 6, 2016
| } | ||
| return Truffle.getRuntime().iterateFrames(frameInstance -> { | ||
| Frame frame = frameInstance.getFrame(FrameAccess.READ_ONLY, true); | ||
| return RubyArguments.tryGetBlock(frame); | ||
| }); |
There was a problem hiding this comment.
iterateFrames finally looks nice!
eregon
reviewed
Oct 6, 2016
| } | ||
|
|
||
| }; | ||
| return () -> iterateKeyValues(firstInSequence); |
There was a problem hiding this comment.
Ah, so Iterable is just () -> Iterator, that makes a lot more sense!
eregon
reviewed
Oct 6, 2016
| return new BaseEventEventNode(context, eventContext, traceFunc, context.getCoreStrings().LINE.createInstance()); | ||
| } | ||
| })); | ||
| instruments.add(instrumenter.attachFactory(SourceSectionFilter.newBuilder().tagIs(LineTag.class).build(), eventContext -> new BaseEventEventNode(context, eventContext, traceFunc, context.getCoreStrings().LINE.createInstance()))); |
eregon
reviewed
Oct 6, 2016
| return (FinalizerReference) finalizerQueue.remove(); | ||
| } | ||
| }); | ||
| FinalizerReference finalizerReference = context.getThreadManager().runUntilResult(null, () -> (FinalizerReference) finalizerQueue.remove()); |
There was a problem hiding this comment.
I think it would be nicer to move the cast outside.
eregon
reviewed
Oct 6, 2016
| public void handle(Signal arg0) { | ||
| // Just ignore the signal. | ||
| } | ||
| SignalHandler IGNORE_HANDLER = arg0 -> { |
There was a problem hiding this comment.
This should probably be named signal.
|
All these cases sound great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.