Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete PointerIO #3400

Merged
merged 2 commits into from
Oct 9, 2016
Merged

Delete PointerIO #3400

merged 2 commits into from
Oct 9, 2016
+33 −56

Conversation

RX14
Copy link
Member

@RX14 RX14 commented Oct 9, 2016

I think the fact that I discovered effectively 3 buffer overflow bugs in String::Formatter while removing PointerIO speaks for itself why we should remove PointerIO.

RX14 added 2 commits October 9, 2016 16:00
@RX14
Fix buffer overflow bugs in String::Formatter

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cda869f
@RX14
Remove PointerIO
f592020
@asterite
Copy link
Member

asterite commented Oct 9, 2016

@RX14 Thank you for this! I wanted to delete this class for a long time but thought it was being used in other places, like Base64. Finally! 😄

@asterite asterite merged commit 42c4405 into crystal-lang:master Oct 9, 2016
@asterite asterite added this to the 0.20.0 milestone Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RX14 @asterite