-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MemoryIO to IO::Memory #3401
Conversation
dfd7ba0
to
349ac1d
Compare
This PR is obviously going to become out of date quite quickly as |
I also think it's more consistent with the other IOs, but typing |
Same here. |
Well, we could rename |
It does feel tidier to group all Crystal IO services under the same namespace. And it could get even better once we develop more advanced editor tools. Just type |
I don't feel like "typing cost" is a particularly good motivation for any change. Most time spent programming is spent looking at or thinking about code, so naming and syntax should be optimised for readability not typability. |
How about StringIO? Easier to find for anyone coming from other languages (Ruby and Python both have StringIO), and fits with the point asterite makes about it being an IO. |
@timcraft except it's not a StringIO because it can contain raw bytes that aren't UTF-8 code points, and renaming just |
Still no movement on this? Unfortunately it's a PR that has to be merged soon after it's updated, and this PR wasn't as simple as running |
@asterite wouldn't this be similar to the decision of renaming While type-to-result ratio for Reading the documentation:
The thing with IMO Cheers. |
Closed by #3563 |
With
IO::Delimited
,IO::Hexdump
etc.IO::Memory
seems like a much more consistent name thanMemoryIO
.