Base64#urlsafe_encode now works as in ruby, fixed #3394 #3403
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Oct 9, 2016
| @@ -149,11 +149,8 @@ module Base64 | |||
| # Alphabet" in RFC 4648. | |||
| # | |||
| # The alphabet uses '-' instead of '+' and '_' instead of '/'. | |||
| # | |||
| # The `padding` parameter defaults to false. When true, enough `=` characters | |||
| # are added to make the output divisible by 3. | |||
| def urlsafe_encode(data, io : IO) | |||
There was a problem hiding this comment.
Should we have padding = true here too?
There was a problem hiding this comment.
i want to remove padding option, and i thought this is not needed, but used in secure_random
https://github.com/crystal-lang/crystal/blob/master/src/secure_random.cr#L46
in io method, i not think it needed
There was a problem hiding this comment.
OK. We can always add it later if needed :-)
|
Looks good, thanks! I added a small question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.