-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more GC.stats #3405
add more GC.stats #3405
Conversation
Thanks! I wanted to this a couple of times but always forgot to do it... :-) |
This seems to have broken my build on arch linux:
It seems from the source as if |
Seems as if the core issue is that the arch package is built with |
|
@kostya but it didn't have a spec before this commit, so |
This is #837 again, but with a different symbol from LibGC. |
Don't worry, we'll eventually provide our own LibGC fork because we already made some changes to it to support multiple threads, so these functions will be available everywhere. |
@asterite how am I meant to contribute to crystal in the meantime? Revert the commit every time I need to run specs, and unrevert every time I need to push? The point is that we're using LibGC's internal API, and that's not portable. |
I see. We can probably remove stats then and someone can provide it as a temporary shard. |
@RX14 Let me know if it compiles now. I think |
No description provided.