Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mirage/mirage
base: 52b383a12b77
Choose a base ref
...
head repository: mirage/mirage
compare: 97955b7f6c94
Choose a head ref
  • 4 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 19, 2016

  1. Invoke pkg-config directly when generating Makefile 

    Rather than invoking pkg-config from within the generated Makefile,
invoke it directly at "configure" time.

Pros:
- This allows us to set variables like "LD" (see #623) sensibly.
- Generated Makefile contains the actual commands which will be run,
rather than call-outs to pkg-config whose output may change at build
time.

Cons:
- "mirage configure" needs to be re-run if dependent packages are
updated, to reflect any new pkg-config variables in the generated
Makefile.
    @mato
    mato committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    5a28986 View commit details
    Browse the repository at this point in the history

  2. Use LD=(...) in generated Makefile

    @mato
    mato committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    9889afa View commit details
    Browse the repository at this point in the history

  3. Remove XENLIB from generated Makefile 

    No longer required for Xen (according to @hannesm) and was never used by
Solo5. Removing this means that the mirage-generated Makefile no longer
needs GNU make.
    @mato
    mato committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    ee26a38 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #627 from mato/invoke-pkgconfig-directly 

    Invoke pkg-config directly when generating Makefile
    @yomimono
    yomimono committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    97955b7 View commit details
    Browse the repository at this point in the history