Item14070: improve attachment link formatting on attach #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the "Create a link to the attached file" formatting options and defaults. - don't default empty $comment to $filename - add $commentorfilename format token/variable - update documentation - update default ATTACHEDFILELINKFORMAT and ATTACHEDIMAGEFORMAT to use $commentorfilename instead of $comment
This reverts commit 7a4b848.
Second, better attempt based on discussion (replaces 7a4b848). - expand common variables (macros) in ATTACHEDFILELINKFORMAT and ATTACHEDIMAGEFORMAT. - solve the problem (of rendering links for files/images with empty comment) using %IF% - update documentation - make Perltidy happy :-/
|
This has been merged into master for 2.2. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://foswiki.org/Tasks/Item14070 for the discussion.