emacs: Use wrapGAppsHook always when on GTK #19731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DamienCassou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @jwiegley and @dudebout to be potential reviewers. |
|
I've been using that for some time now and it seems to work. Can I merge it? |
|
I have the impression that this patch triggers a lot of warning messages in the terminal: this seem harmless but are still annoying. |
Could we alter the hook so it doesn't point GTK to non-existent directories? |
|
This seems to be done in master now, albeit in a slightly different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The GTK theme is not recognized (e.g., the mouse pointer is different when inside an Emacs window).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)