Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soften test deps HTTP::Tiny::Mech and WWW::Mechanize::Cached #50

Merged
merged 1 commit into from Oct 21, 2016
Merged

Soften test deps HTTP::Tiny::Mech and WWW::Mechanize::Cached #50

merged 1 commit into from Oct 21, 2016

Conversation

pghmcfc
Copy link

@pghmcfc pghmcfc commented Oct 21, 2016

They are already listed as test recommends

@pghmcfc
Soften test deps HTTP::Tiny::Mech and WWW::Mechanize::Cached
8bbc016 
They are already listed as test recommends
pghmcfc referenced this pull request Oct 21, 2016
@mickeyn
take prereqs from cpanfile
529d2de
@mickeyn mickeyn merged commit afd8423 into metacpan:master Oct 21, 2016
@mickeyn
Copy link
Contributor

mickeyn commented Oct 21, 2016

thanks

oalders
oalders reviewed Oct 21, 2016
View reviewed changes
cpanfile
@@ -16,14 +16,12 @@ requires "warnings" => "0";

on 'test' => sub {
requires "File::Spec" => "0";
requires "HTTP::Tiny::Mech" => "0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just have been switched from requires to recommends?

@pghmcfc
Copy link
Author

pghmcfc commented Oct 21, 2016

@oalders, it was both a requires and a recommends; I just got rid of the requires, leaving the recommends untouched.

@mickeyn
Copy link
Contributor

mickeyn commented Oct 21, 2016

@oalders the recommends already exist in a the separate section you added for it :)

@oalders
Copy link
Member

oalders commented Oct 21, 2016

I guess I shouldn't have checked only the diff. :) Thanks @pghmcfc and @mickeyn.

@mickeyn
Copy link
Contributor

mickeyn commented Oct 21, 2016

I think these were added by dzil automatically... i'll fix the dist.ini not to do that on every build.

@pghmcfc
Copy link
Author

pghmcfc commented Oct 22, 2016

Something went wrong with the 1.028000 release; the deps are unchanged and cpanfile wasn't included in the release tarball.

@mickeyn
Copy link
Contributor

mickeyn commented Oct 22, 2016

yeah, my change did that.
the problem is that with the current setup dzil changes the cpanfile to include those lines you removed and they get included in the shipped cpanfile.
I'm trying to find a way to prevent that and will appreciate help if you are proficient with dzil.

@pghmcfc
Copy link
Author

pghmcfc commented Oct 22, 2016

I'm afraid my skillset is in downstream packaging for Fedora rather than dzil; if I knew dzil I'd probably have been able to include whatever was needed in the PR ... sorry

@oalders
Copy link
Member

oalders commented Oct 22, 2016

See #51

@oalders
Copy link
Member

oalders commented Oct 22, 2016

Actually, I don't think that fixes this issue, but it fixes a build problem.

@oalders
Copy link
Member

oalders commented Oct 22, 2016

See #52 for the fix to this issue.

@mickeyn
Copy link
Contributor

mickeyn commented Oct 22, 2016

@oalders thanks for all the fixes. release 1.028001 will ship with a better cpanfile now.

@pghmcfc
Copy link
Author

pghmcfc commented Oct 22, 2016

1.028001 now has the right cpanfile but the Makefile.PL and META.* still have the old hard dependencies.

@mickeyn
Copy link
Contributor

mickeyn commented Oct 23, 2016

@pghmcfc 1.028003 deals with that issue

@mickeyn
Copy link
Contributor

mickeyn commented Oct 23, 2016

thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalders oalders oalders left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pghmcfc @mickeyn @oalders