String#partition #3435
String#partition #3435
Conversation
| @@ -2200,6 +2200,45 @@ class String | |||
| match_result.try &.begin(0) | |||
| end | |||
|
|
|||
| # Searches sep or pattern (regexp) in the string, | |||
| # and returns the part before it, the match, and the part after it. | |||
| # If it is not found, returns two empty strings and str. | |||
There was a problem hiding this comment.
This should be returns str followed by two empty strings. Also, the examples below are incorrectly using rpartition instead of partition (and the second example has the result of rpatition)
There was a problem hiding this comment.
crap, thats what happens when you try to rush a feature through at midnight
| # "hello".rpartition("x") # => {"hello", "", ""} | ||
| # ``` | ||
| def partition(search : (Char | String)) : Tuple(String, String, String) | ||
| pre, mid, post = {"", "", ""} |
There was a problem hiding this comment.
I think this is much simpler:
pre = mid = post = ""But in fact maybe you could assign these variables in each case, or maybe just return a different tuple in every case branch.
There was a problem hiding this comment.
ooooh i like that .... cant believe i missed it ;-)
There was a problem hiding this comment.
It's ok, in any case the performance should be the same. You can also do:
pre, mid, post = "", "", ""That is, you don't need the tuple on the right. But the shortest one, maybe the clearest one, is the chained assignment.
There was a problem hiding this comment.
yeah i like the chained version, its very clear
|
Thank you! ❤️ |
No description provided.