Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot iterate over a Range of Times #4231

Closed
drcapulet opened this issue Oct 17, 2016 · 4 comments
Closed

Cannot iterate over a Range of Times #4231

drcapulet opened this issue Oct 17, 2016 · 4 comments
Labels
core JRuby 9000
Milestone
JRuby 9.1.6.0

Comments

@drcapulet
Copy link

Environment

  • jruby 9.0.5.0 (2.2.3) 2016-01-26 7bee00d Java HotSpot(TM) 64-Bit Server VM 25.92-b14 on 1.8.0_92-b14 [darwin-x86_64]
  • jruby 9.1.2.0 (2.3.0) 2016-05-26 7357c8f Java HotSpot(TM) 64-Bit Server VM 25.92-b14 on 1.8.0_92-b14 [darwin-x86_64]
  • jruby 9.1.5.0 (2.3.1) 2016-09-07 036ce39 Java HotSpot(TM) 64-Bit Server VM 25.92-b14 on 1.8.0_92-b14 [darwin-x86_64]
  • Mac OS X 10.11.6

Expected Behavior

irb(main):001:0> (Time.now..(Time.now+60)) === Time.now
=> true
irb(main):002:0> (Time.now..(Time.now+60)) === Time.now - 1
=> false
irb(main):003:0> (Time.now..(Time.now+60)) === Time.now + 59
=> true
irb(main):004:0> (Time.now..(Time.now+60)) === Time.now + 61
=> false

Under MRI 2.2+

Actual Behavior

irb(main):001:0> (Time.now..(Time.now+60)) === Time.now
TypeError: can't iterate from Time
    from org/jruby/RubyRange.java:481:in `each'
    from org/jruby/RubyEnumerable.java:1225:in `include?'
    from org/jruby/RubyRange.java:710:in `include?'
    from org/jruby/RubyRange.java:715:in `==='
    from (irb):1:in `<eval>'
    from org/jruby/RubyKernel.java:995:in `eval'
    from org/jruby/RubyKernel.java:1296:in `loop'
    from org/jruby/RubyKernel.java:1115:in `catch'
    from org/jruby/RubyKernel.java:1115:in `catch'
    from /Users/alexc/.rbenv/versions/jruby-9.1.5.0/bin/irb:13:in `<main>'
@headius
Copy link
Member

headius commented Oct 18, 2016

How peculiar...we have code that explicitly checks for Time and raises this error.

@headius
Copy link
Member

headius commented Oct 18, 2016

So it looks like MRI does not actually trigger iteration for the == call here while JRuby does. If I actually try to iterate over a range, MRI raises the same error:

[] ~/projects/ruby $ ruby23 -e '(Time.now..(Time.now+60)) === Time.now + 61'

[] ~/projects/ruby $ ruby23 -e '(Time.now..(Time.now+60)).each {}'
-e:1:in `each': can't iterate from Time (TypeError)
    from -e:1:in `<main>'

This is telling me that what you expect may not be correct. MRI does appear to try to prevent iteration over a range of Time.

@headius
Copy link
Member

headius commented Oct 18, 2016

Ok, I found the logic. MRI allows Time ranges to use cover? for include?, which avoids the iteration and error.

headius added a commit that referenced this issue Oct 18, 2016
@headius
Add spec for Range#include? with Time endpoints.
34a6af3 
See #4231.
@headius headius added this to the JRuby 9.1.6.0 milestone Oct 18, 2016
@drcapulet
Copy link
Author

Thanks for the quick fix @headius!

eregon pushed a commit to ruby/spec that referenced this issue Oct 29, 2016
@headius @eregon
Add spec for Range#include? with Time endpoints.
fe9e1d1 
See jruby/jruby#4231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 9000
Projects
None yet
Milestone
JRuby 9.1.6.0
Development

No branches or pull requests
2 participants
@headius @drcapulet