Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks
PTY#spawn
to useopenpty(3)
(available on BSD, OS X and Linux) andProcess#spawn
instead offorkpty(3)
, which as the name suggests, forks and is thus unsafe. It also fixes use with multiple arguments.It also adds
PTY#open
andPTY#check
, and properly definesPTY#getpty
as an alias toPTY#spawn
.It passes MRI's test_pty.rb, after a slight tweak to close a race condition:
Needs testing and review, especially outside FreeBSD.