Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement for varargs when generating Class objects #3231

Closed

Conversation

rtyler
Copy link

@rtyler rtyler commented Aug 6, 2015

This is effectively a patch written by @headius and tested locally and applied
by me. In my use-case this allows Java code to properly reflect back into a
Ruby-generated Class and invoke a method which takes no arguments.

Fixes #3206

…Java

This is effectively a patch written by @headius and tested locally and applied
by me. In my use-case this allows Java code to properly reflect back into a
Ruby-generated Class and invoke a method which takes no arguments.

Fixes jruby#3206
@kares
Copy link
Member

kares commented Aug 26, 2015

seems like this would be useful on jruby-1_7 as well ?

@rtyler
Copy link
Author

rtyler commented Aug 26, 2015

@kares I agree, this was really @headius' patch from JRubyConf EU, so I figured he'd take it over at some point :)

@kares
Copy link
Member

kares commented May 30, 2016

#3206 has been fixed - a similar change came in with #3779 (in JRuby 9.1)

@kares kares closed this May 30, 2016
@kares kares added this to the Invalid or Duplicate milestone May 30, 2016
@headius
Copy link
Member

headius commented May 31, 2016

Hah, I totally forgot about this. Thanks @kares!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants