i2pd: 2.15.0 -> 2.17.0 #34063
i2pd: 2.15.0 -> 2.17.0 #34063
Conversation
| }; | ||
|
|
||
| buildInputs = [ boost zlib openssl ]; | ||
| buildInputs = [ boost165 zlib openssl ]; |
There was a problem hiding this comment.
Thank you! Please override versions in all-packages.nix, like this:
nixpkgs/pkgs/top-level/all-packages.nix
Lines 790 to 792 in 836951f
There was a problem hiding this comment.
Oops. Should I override derivations which have a version in the name like this(boost*, python*, python*Packages, ...) for every package I change? Is it a common approach? Asking because I have other PR where it is probably could be a good thing :)
There was a problem hiding this comment.
This is mostly useful for tracking which derivations depend on older versions (that will be deleted in the future once no package depends on them) and trying to switch them to newer versions of their dependencies en masse. This does not quite apply to python (python3 can be seen as less an upgrade and more a different thing, like qt4 and qt5, gtk2 and gtk3, gnupg1 and gnupg, grub and grub2), so IMHO both approaches are fine, and AFAIK referring to python3 in Python 3 derivations is more prevalent.
Motivation for this change
Updating to the last version of i2pd. Also this PR fixing the failing i2pd build(looks like boost version in nixpkgs is too fresh).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)