Skip to content

KSP physics #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 20, 2018
Merged

KSP physics #1686

merged 31 commits into from
Jan 20, 2018

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 19, 2018

A separate DLL with instantiations of Ephemeris, ContinuousTrajectory, and Body and its subclasses, for optimization and benchmarking.

This requires mockingbirdnest/protobuf#3.

@pleroy pleroy added the LGTM label Jan 20, 2018
Principia.sln Outdated
@@ -467,6 +469,27 @@ Global
{A0E67E1B-E5A6-45A0-B42C-4330A6643CD7}.Release|Win32.Build.0 = Release|Any CPU
{A0E67E1B-E5A6-45A0-B42C-4330A6643CD7}.Release|x64.ActiveCfg = Release|Any CPU
{A0E67E1B-E5A6-45A0-B42C-4330A6643CD7}.Release|x64.Build.0 = Release|Any CPU
{3882467C-89D7-4DAE-9730-BB2E610F05AD}.Debug|Any CPU.ActiveCfg = Debug|Win32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the Any CPU.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

int const line,
std::string const& message) {
LOG_AT_LEVEL(level) << "[" << filename << ":" << line << "] " << message;
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@eggrobin eggrobin merged commit 3c3da1a into mockingbirdnest:master Jan 20, 2018
@eggrobin eggrobin mentioned this pull request Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants